Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Updates GitHub Actions #1085

Draft
wants to merge 4 commits into
base: 7.x
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions .github/workflows/2.7.yml

This file was deleted.

14 changes: 8 additions & 6 deletions .github/workflows/2.6.yml → .github/workflows/7x_tests.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Ruby 2.6
name: 7x tests
on:
push:
branches:
- main
- 7.x
pull_request:
branches:
- main
- 7.x
workflow_dispatch:
branches:
- '*'
Expand All @@ -16,9 +16,11 @@ jobs:
RAILS_VERSIONS: '5.0,6.0'
strategy:
fail-fast: false
matrix:
ruby: [ '2.6', '2.7', '3.0' ]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Increase system limits
run: |
sudo swapoff -a
Expand All @@ -30,11 +32,11 @@ jobs:
stack-version: 7.x-SNAPSHOT
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
ruby-version: ${{ matrix.ruby }}
- name: Bundle
run: |
sudo apt-get install libsqlite3-dev
gem install bundler
gem install bundler -v 2.4.22
bundle install
bundle exec rake bundle:clean
bundle exec rake bundle:install
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/jruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: JRuby
on:
push:
branches:
- main
- 7.x
pull_request:
branches:
- main
- 7.x
workflow_dispatch:
branches:
- '*'
Expand All @@ -16,6 +16,8 @@ jobs:
RAILS_VERSIONS: '5.0,6.0'
strategy:
fail-fast: false
matrix:
ruby: [ 'jruby-9.3', 'jruby-9.4' ]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -27,13 +29,12 @@ jobs:
sudo sysctl -w vm.max_map_count=262144
- uses: elastic/elastic-github-actions/elasticsearch@master
with:
stack-version: 7.x-SNAPSHOT
stack-version: 7.17-SNAPSHOT
- uses: ruby/setup-ruby@v1
with:
ruby-version: jruby-9.3
ruby-version: ${{ matrix.ruby }}
- name: Bundle
run: |
sudo apt-get install libsqlite3-dev
gem install bundler
bundle install
bundle exec rake bundle:clean
Expand Down
1 change: 1 addition & 0 deletions elasticsearch-model/Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ namespace :test do
puts '-' * 80
gemfiles.each do |gemfile|
puts "GEMFILE: #{gemfile}"
sh "BUNDLE_GEMFILE='#{File.expand_path("../gemfiles/#{gemfile}", __FILE__)}' bundle install"
sh "BUNDLE_GEMFILE='#{File.expand_path("../gemfiles/#{gemfile}", __FILE__)}' " \
' bundle exec rspec'
puts '-' * 80
Expand Down
2 changes: 1 addition & 1 deletion elasticsearch-model/gemfiles/5.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ gemspec path: '../'

gem 'activemodel', '~> 5'
gem 'activerecord', '~> 5'
gem 'sqlite3' unless defined?(JRUBY_VERSION)
gem 'sqlite3', '> 1.3', '< 1.4' unless defined?(JRUBY_VERSION)
gem 'mongoid', '~> 6'

group :development, :testing do
Expand Down
5 changes: 5 additions & 0 deletions elasticsearch-model/lib/elasticsearch/model.rb
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ class << self
METHODS.each do |method|
delegate method, to: :__elasticsearch__ unless self.public_instance_methods.include?(method)
end

def inherited(subclass)
super
Registry.add(subclass) if subclass.is_a?(Class)
end
end
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@
it 'imports all documents' do
expect(ImportArticle.search('*').results.total).to eq(10)
end

it "does not pollute the model's namespace" do
expect(ImportArticle.methods).not_to include(:__transform)
end
end

context 'when batch size is specified' do
Expand Down
4 changes: 4 additions & 0 deletions elasticsearch-model/spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
require 'yaml'
require 'active_record'

# Load all of ActiveSupport to be sure of complete compatibility -
# see https://github.com/elastic/elasticsearch-rails/pull/1075 for details
require 'active_support/all'

unless defined?(ELASTICSEARCH_URL)
ELASTICSEARCH_URL = ENV['ELASTICSEARCH_URL'] || "localhost:#{(ENV['TEST_CLUSTER_PORT'] || 9200)}"
end
Expand Down
Loading