Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Updates GitHub Actions #1085

Draft
wants to merge 4 commits into
base: 7.x
Choose a base branch
from
Draft

[CI] Updates GitHub Actions #1085

wants to merge 4 commits into from

Commits on Sep 5, 2024

  1. [CI] Updates GitHub Actions 

    Lock bundler to v 2.4.22, since Ruby old :(
Removes unnecessary package installation
Updates STACK_VERSION
Adds jruby 9.4
Run bundle install with BUNDLE_GEMFILE
Updates actions/checkout
sqlite for Rails 5 shenanigans
    @picandocodigo
    picandocodigo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d32af9a View commit details
    Browse the repository at this point in the history

  2. Require activesupport/all to more closely mirror a production Rails app. 

    ActiveSupport patches Kernel to add `class_eval` but this behavior wasn't
loaded in the test environment. This created a discrepancy between test
and prod, causing tests to fail that should have passed and vice versa.
Fully loading ActiveSupport makes the test environment more accurate.
    @sinisterchipmunk @picandocodigo
    sinisterchipmunk authored and picandocodigo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8ebd78d View commit details
    Browse the repository at this point in the history

  3. Ensure subclasses are added to the registry

    @martinstreicher @picandocodigo
    martinstreicher authored and picandocodigo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f104d3d View commit details
    Browse the repository at this point in the history

  4. Test that the model namespace isn't polluted. 

    The goal of ClassMethodsProxy is to avoid polluting the target's namespace,
but it was possible to do this by accident when calling `class_eval` before
ActiveSupport was completely loaded. This test ensures the namespace isn't
polluted, regardless of the load state of ActiveSupport.
    @sinisterchipmunk @picandocodigo
    sinisterchipmunk authored and picandocodigo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2939703 View commit details
    Browse the repository at this point in the history