Validate the proper value of event.dataset #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event.dataset field must have as value the name of the package and the name of the data stream, separated by a dot.
jsoriano
commented
Sep 8, 2022
| Fix the value in the field definition using a `constant_keyword`: | ||
| ``` | ||
| - name: event.dataset | ||
| type: constant_keyword |
There was a problem hiding this comment.
This is not possible now. We don't allow to override the type of an imported value. But I think it would make sense to support the change from keyword to constant_keyword. I will open a PR to support it.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
16 tasks
mrodm
reviewed
Sep 8, 2022
mrodm
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
event.datasetanddata_stream.datasetfields are used, they must have as values the name of the package and the name of the data stream, separated by a dot.Fixes elastic/package-spec#217.
Part of elastic/package-spec#399.