Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new lint/check to ensure event.dataset is set correctly #217

Closed
Tracked by #399
P1llus opened this issue Aug 16, 2021 · 0 comments · Fixed by elastic/elastic-package#968
Closed
Tracked by #399

Add new lint/check to ensure event.dataset is set correctly #217

P1llus opened this issue Aug 16, 2021 · 0 comments · Fixed by elastic/elastic-package#968
Assignees

Comments

@P1llus
Copy link
Member

P1llus commented Aug 16, 2021

When adding event.dataset to a package in base-fields.yml, there is no check or lint that complains if the value is not "package.datastream", for example

Package panw_cortex_xdr, datastream: alerts

- name: event.dataset
  type: constant_keyword
  description: Event dataset
  value: panw_cortex.xdr

When starting the stack and testing the package manually, it complains that event.dataset is not set to panw_cortex_xdr.alerts, however it would be nice to do this check already on build/lint, saves time in the future, and makes sure no human error might cause it (like I did).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants