fix: path of stacked area series with missing values #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
+ Coverage 73.13% 75.16% +2.03%
==========================================
Files 271 279 +8
Lines 8784 8815 +31
Branches 1747 1736 -11
==========================================
+ Hits 6424 6626 +202
+ Misses 2309 2132 -177
- Partials 51 57 +6
Continue to review full report at Codecov.
|
markov00
reviewed
Jun 12, 2020
browsers/browsers.test.ts
Outdated
| @@ -60,6 +60,15 @@ describe('smoke tests', () => { | |||
| }); | |||
|
|
|||
| afterAll(async() => { | |||
| const entries = await driver.manage().logs().get(logging.Type.BROWSER); | |||
| console.log('EEEERRORS', JSON.stringify(entries)); | |||
There was a problem hiding this comment.
MMMMMM ppppprrrrooobbbbabbblyyy wwwweeee shhhhhooouuuuulddd fiiiix thiiiiiis tttttttypoooooo :D
There was a problem hiding this comment.
removed see force push
markov00
approved these changes
Jun 12, 2020
nickofthyme
force-pushed
the
fix/stacked-missing-value
branch
from
6063029 to
c5490c2
Compare
|
@markov00 yeah I first thought that screenshot was broken but then I realized I fixed it 😍 |
markov00
pushed a commit
that referenced
this pull request
Jun 15, 2020
# [19.5.0](v19.4.1...v19.5.0) (2020-06-15) ### Bug Fixes * **tooltip:** show true opaque colors in tooltips ([#629](#629)) ([23290be](23290be)), closes [#628](#628) * path of stacked area series with missing values ([#703](#703)) ([2541180](2541180)) * remove double rendering ([#693](#693)) ([ebf2748](ebf2748)), closes [#690](#690) ### Features * **partition:** add 4.5 contrast for text in partition slices ([#608](#608)) ([eded2ac](eded2ac)), closes [#606](#606) * add screenshot functions to partition/goal ([#697](#697)) ([5581c3c](5581c3c))
|
🎉 This PR is included in version 19.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
nickofthyme
referenced
this pull request
Sep 15, 2020
This commit adds the wiggle and silhouette stacks mode as available in vislib that allow the creation of streamgraph. It is also to fix fit functions for stacked charts. The commit also add the following fixes: - fit functions are now available also on stacked charts - the legend extra value is now displayed, on-demand, only on charts with a continuous x-axis - Adjusts slightly the way fitted data is represented in the case of null values and no fit option specified. It renders an empty area in this case - for zero-based charts (bar and area charts) the fit option doesn't have any effects - djusts the clipped ranges for ordinal charts, where the lines where wrongly clipped due to a missing translate call when rendering BREAKING CHANGE: the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`. fix #766 fix #715 close #450
4 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [19.5.0](elastic/elastic-charts@v19.4.1...v19.5.0) (2020-06-15) ### Bug Fixes * **tooltip:** show true opaque colors in tooltips ([opensearch-project#629](elastic/elastic-charts#629)) ([323b325](elastic/elastic-charts@323b325)), closes [opensearch-project#628](elastic/elastic-charts#628) * path of stacked area series with missing values ([opensearch-project#703](elastic/elastic-charts#703)) ([93f063f](elastic/elastic-charts@93f063f)) * remove double rendering ([#693](elastic/elastic-charts#693)) ([1a9bbb9](elastic/elastic-charts@1a9bbb9)), closes [#690](elastic/elastic-charts#690) ### Features * **partition:** add 4.5 contrast for text in partition slices ([opensearch-project#608](elastic/elastic-charts#608)) ([59d6d49](elastic/elastic-charts@59d6d49)), closes [opensearch-project#606](elastic/elastic-charts#606) * add screenshot functions to partition/goal ([opensearch-project#697](elastic/elastic-charts#697)) ([6d2ff64](elastic/elastic-charts@6d2ff64))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #680
Accounts for sorted
xValueswhen sorting filled missing values.Checklist
Delete any items that are not applicable to this PR.