Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove kibana issue from /packages/osd-optimizer/README.md #608

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 8, 2021

Description

/packages/osd-optimizer/README.md has a kibana issue reference. This PR
removes the issue.

Partically Resolved:

#592

Signed-off-by: Anan Zhuang [email protected]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added bug Something isn't working v1.0.0 labels Jul 8, 2021
@ananzh ananzh requested review from tmarkley, ahopp and kavilla July 8, 2021 22:42
@ananzh ananzh self-assigned this Jul 8, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 452699c

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have replacement issue or we are removing this because we do not foresee us implementing this ?

/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
opensearch-project#592

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh force-pushed the fix_osd_optimizer branch from 452699c to aeda2bd Compare July 9, 2021 16:41
@ananzh
Copy link
Member Author

ananzh commented Jul 9, 2021

Do we have replacement issue or we are removing this because we do not foresee us implementing this ?

Nice catch. I opened an issue for us to track and discuss. Will modify this issue when I get a bit more time to investigate.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed aeda2bd

@ananzh ananzh requested review from seraphjiang and mihirsoni July 9, 2021 17:53
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! I reference old issue in issue to just have better link.

@ananzh
Copy link
Member Author

ananzh commented Jul 9, 2021

I will close this one for now. We haven't decided what we want to do for replacing kibana issues. These kibana issues contains useful discussions, ideas from many contributors. If we replace them with any investigation, we will lose these info and might cause duplicate work. It is better to replace once we have time to investigate the issue. Need more discussion.

@ananzh ananzh removed the v1.0.0 label Jul 9, 2021
@kavilla kavilla self-requested a review July 12, 2021 20:13
@ananzh ananzh merged commit 8ec5c7b into opensearch-project:main Jul 12, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 12, 2021
…arch-project#608)

/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#597

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 12, 2021
…arch-project#608)

/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#597

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 12, 2021
/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#608

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 12, 2021
/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#608

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit that referenced this pull request Jul 13, 2021
/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
#592

Backport PR:
#608

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit that referenced this pull request Jul 13, 2021
/packages/osd-optimizer/README.md has a kibana issue reference. This PR
replaces the kibana issue with an open discuss issue.

Partically Resolved:
#592

Backport PR:
#608

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh added the v1.1.0 label Jul 13, 2021
@tmarkley tmarkley added the docs Improvements or additions to documentation label Aug 5, 2021
@ananzh ananzh deleted the fix_osd_optimizer branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation v1.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants