-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: control which parts are shown in partition charts #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working the way I expect it to- I built it locally and was able to configure the hidden slices like we had previously talked about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally
# [18.1.0](v18.0.0...v18.1.0) (2020-03-18) ### Bug Fixes * add unicorn eslint as dev dependency ([#591](#591)) ([30fd07c](30fd07c)) ### Features * remove duplicate tick labels from axis ([#577](#577)) ([e8c89ec](e8c89ec)), closes [#445](#445) * **api:** cleanup exposed types ([#593](#593)) ([544b7cc](544b7cc)) * **partition:** general sunburst via slice show control ([#592](#592)) ([5e6a30b](5e6a30b))
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [18.1.0](elastic/elastic-charts@v18.0.0...v18.1.0) (2020-03-18) ### Bug Fixes * add unicorn eslint as dev dependency ([opensearch-project#591](elastic/elastic-charts#591)) ([7c7ccfe](elastic/elastic-charts@7c7ccfe)) ### Features * remove duplicate tick labels from axis ([opensearch-project#577](elastic/elastic-charts#577)) ([52c6921](elastic/elastic-charts@52c6921)), closes [opensearch-project#445](elastic/elastic-charts#445) * **api:** cleanup exposed types ([opensearch-project#593](elastic/elastic-charts#593)) ([0b964c6](elastic/elastic-charts@0b964c6)) * **partition:** general sunburst via slice show control ([opensearch-project#592](elastic/elastic-charts#592)) ([7240823](elastic/elastic-charts@7240823))
Summary
Optionally control (restrict) which parts, ie. slices/sectors/rectangles are shown. The not shown ones are ignored for the purpose of tooltips too.
The main use of it is to allow the creation of general sunburst charts where the depth of the tree is non-uniform.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts
(and stories only import from../src
except for test data & storybook)