Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: control which parts are shown in partition charts #592

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Mar 17, 2020

Summary

Optionally control (restrict) which parts, ie. slices/sectors/rectangles are shown. The not shown ones are ignored for the purpose of tooltips too.

The main use of it is to allow the creation of general sunburst charts where the depth of the tree is non-uniform.

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@monfera monfera requested a review from markov00 March 17, 2020 19:06
@monfera monfera self-assigned this Mar 17, 2020
Copy link

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working the way I expect it to- I built it locally and was able to configure the hidden slices like we had previously talked about.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

@monfera monfera merged commit 5e6a30b into elastic:master Mar 18, 2020
@monfera monfera deleted the heterogeneous branch March 18, 2020 16:49
markov00 pushed a commit that referenced this pull request Mar 18, 2020
# [18.1.0](v18.0.0...v18.1.0) (2020-03-18)

### Bug Fixes

* add unicorn eslint as dev dependency ([#591](#591)) ([30fd07c](30fd07c))

### Features

* remove duplicate tick labels from axis ([#577](#577)) ([e8c89ec](e8c89ec)), closes [#445](#445)
* **api:** cleanup exposed types ([#593](#593)) ([544b7cc](544b7cc))
* **partition:** general sunburst via slice show control ([#592](#592)) ([5e6a30b](5e6a30b))
@markov00
Copy link
Member

🎉 This PR is included in version 18.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 18, 2020
@markov00
Copy link
Member

🎉 This PR is included in version 18.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @18.1.x released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants