fix: add unicorn eslint as dev dependency #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
+ Coverage 70.23% 70.55% +0.32%
==========================================
Files 208 220 +12
Lines 6238 6392 +154
Branches 1208 1183 -25
==========================================
+ Hits 4381 4510 +129
- Misses 1839 1863 +24
- Partials 18 19 +1
Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
Mar 18, 2020
# [18.1.0](v18.0.0...v18.1.0) (2020-03-18) ### Bug Fixes * add unicorn eslint as dev dependency ([#591](#591)) ([30fd07c](30fd07c)) ### Features * remove duplicate tick labels from axis ([#577](#577)) ([e8c89ec](e8c89ec)), closes [#445](#445) * **api:** cleanup exposed types ([#593](#593)) ([544b7cc](544b7cc)) * **partition:** general sunburst via slice show control ([#592](#592)) ([5e6a30b](5e6a30b))
|
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
|
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [18.1.0](elastic/elastic-charts@v18.0.0...v18.1.0) (2020-03-18) ### Bug Fixes * add unicorn eslint as dev dependency ([opensearch-project#591](elastic/elastic-charts#591)) ([7c7ccfe](elastic/elastic-charts@7c7ccfe)) ### Features * remove duplicate tick labels from axis ([opensearch-project#577](elastic/elastic-charts#577)) ([52c6921](elastic/elastic-charts@52c6921)), closes [opensearch-project#445](elastic/elastic-charts#445) * **api:** cleanup exposed types ([opensearch-project#593](elastic/elastic-charts#593)) ([0b964c6](elastic/elastic-charts@0b964c6)) * **partition:** general sunburst via slice show control ([opensearch-project#592](elastic/elastic-charts#592)) ([7240823](elastic/elastic-charts@7240823))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I had incorrectly added
"eslint-plugin-unicorn"as a dependency not a devDependency. This PR correctly adds the plugin to the devDependencies and removes it from the core dependency for elastic-charts.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)- [ ] Proper documentation or storybook story was added for features that require explanation or tutorials- [ ] Unit tests were updated or added to match the most common scenarios