Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: xDomain exclude undefined values #440

Merged
merged 1 commit into from
Oct 25, 2019
Merged

fix: xDomain exclude undefined values #440

merged 1 commit into from
Oct 25, 2019

Conversation

nickofthyme
Copy link
Collaborator

Summary

Prevent undefined or null values in xValues

fixes #439

Checklist

  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme nickofthyme requested a review from markov00 October 24, 2019 20:14
@codecov-io
Copy link

codecov-io commented Oct 24, 2019 •
edited
Loading

Codecov Report

Merging #440 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   97.88%   97.88%   +<.01%     
==========================================
  Files          41       41              
  Lines        2925     2927       +2     
  Branches      708      710       +2     
==========================================
+ Hits         2863     2865       +2     
  Misses         55       55              
  Partials        7        7
Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/series.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783364d...2cdcee5. Read the comment docs.

markov00
markov00 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme nickofthyme merged commit 6389356 into elastic:master Oct 25, 2019
markov00 pushed a commit that referenced this pull request Oct 25, 2019
@semantic-release-bot
chore(release): 13.5.8 [skip ci]
f6c5d27 
## [13.5.8](v13.5.7...v13.5.8) (2019-10-25)

### Bug Fixes

* xDomain to exclude undefined values ([#440](#440)) ([6389356](6389356))
@markov00
Copy link
Member

🎉 This PR is included in version 13.5.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 25, 2019
@nickofthyme nickofthyme deleted the fix/domain-error branch November 1, 2019 15:48
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 13.5.8 [skip ci]
c1ab755 
## [13.5.8](elastic/elastic-charts@v13.5.7...v13.5.8) (2019-10-25)

### Bug Fixes

* xDomain to exclude undefined values ([opensearch-project#440](elastic/elastic-charts#440)) ([54a6bf1](elastic/elastic-charts@54a6bf1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart can throw uncatchable errors if missing data
3 participants
@nickofthyme @codecov-io @markov00