fix: xDomain to exclude undefined values (opensearch-project#440)

AMoo-Miki · Oct 25, 2019 · 54a6bf1 · 54a6bf1
1 parent 512fdc0
commit 54a6bf1
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/packages/osd-charts/src/chart_types/xy_chart/utils/series.ts b/packages/osd-charts/src/chart_types/xy_chart/utils/series.ts
@@ -120,18 +120,25 @@ export function splitSeries(
         const colorValuesKey = getColorValuesAsString(colorValues, specId);
         colorsValues.set(colorValuesKey, colorValues);
         const cleanedDatum = cleanDatum(datum, xAccessor, accessor, y0Accessors && y0Accessors[index]);
-        xValues.add(cleanedDatum.x);
-        updateSeriesMap(series, [...seriesKey, accessor], cleanedDatum, specId, colorValuesKey);
+
+        if (cleanedDatum.x !== null && cleanedDatum.x !== undefined) {
+          xValues.add(cleanedDatum.x);
+          updateSeriesMap(series, [...seriesKey, accessor], cleanedDatum, specId, colorValuesKey);
+        }
       });
     } else {
       const colorValues = getColorValues(datum, splitSeriesAccessors);
       const colorValuesKey = getColorValuesAsString(colorValues, specId);
       colorsValues.set(colorValuesKey, colorValues);
       const cleanedDatum = cleanDatum(datum, xAccessor, yAccessors[0], y0Accessors && y0Accessors[0]);
-      xValues.add(cleanedDatum.x);
-      updateSeriesMap(series, [...seriesKey], cleanedDatum, specId, colorValuesKey);
+
+      if (cleanedDatum.x !== null && cleanedDatum.x !== undefined) {
+        xValues.add(cleanedDatum.x);
+        updateSeriesMap(series, [...seriesKey], cleanedDatum, specId, colorValuesKey);
+      }
     }
   });
+
   return {
     rawDataSeries: [...series.values()],
     colorsValues,