feat(bullet): new design style and implementation #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add angular bullet subtype - Add size types for angular subtype with dynamic placement - Improve and centralize maxTicks logic - Separate subtype implementations - A debug rendering - Simplify value/target label formatting with postfix - Add angular story
nickofthyme
added
enhancement
nickofthyme
changed the title
9 tasks
- add reverse option to angular bull - update angle limiting sized for grid
- add bandColors and angular tick padding the theme - add configurable tick snap step - tweaks to add pointer events next
- add tooltip with active, target and actual values - derive active hovered value - shared active values across SM panels
- add targetFormatter - fix target/value header formatting - add locale to wrapText in bullet layout calcs - add hover titles to metric progress bar and target - make progress size style more clear
- remove conditional rendering of active value, use tooltip none instead - move reverse option to BulletDatum options
nickofthyme
commented
Nov 6, 2023
packages/charts/src/chart_types/bullet_graph/renderer/canvas/index.tsx
Outdated
Show resolved
Hide resolved
nickofthyme
added
:bullet
|
buildkite update screenshots |
gvnmagni
approved these changes
Nov 9, 2023
nickofthyme
pushed a commit
that referenced
this pull request
Nov 20, 2023
# [61.1.0](v61.0.0...v61.1.0) (2023-11-20) ### Bug Fixes * **deps:** update dependency @elastic/eui to v91 ([#2233](#2233)) ([e89f623](e89f623)) * **metric:** add option to set empty cell background color ([#2247](#2247)) ([6a9fb86](6a9fb86)) * **metric:** background color for bar with interactions ([#2248](#2248)) ([dcb56fa](dcb56fa)) ### Features * **bullet:** improve header layout and positioning ([#2243](#2243)) ([b3a95d2](b3a95d2)) * **bullet:** new design style and implementation ([#2156](#2156)) ([fca6cdd](fca6cdd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major overhaul of the design of bullet chart, now with a brand new chart implementation under the hood.
Screen.Recording.2023-11-08.at.07.44.18.PM.mp4
Details
The new design includes a
Bulletas aMetricfeature that automatically converts crammed bullet charts in to an equivalent but simplified version as aMetric. These breakpoints are based on the subtype used and the contents of thetitleandsubtitle.No breaking changes but this does deprecate the old
Goalspec in favor of this newBulletspec.Issues
Old Goal/Gauge chart issue fixed by new implementation
closes #2095 - To consider fixing last ticks to right/top across bullet and all axes charts in the future
closes #1845 - Now uses a custom tooltip with active, target and current value
closes #1703 - No longer applies
closes #1648 - Complete redesign of chart
closes #1626 - No longer applies
closes #1604 - No longer applies
closes #1601 - No longer applies except for ask for common label
closes #1600 - No longer applies
closes #1508 - Better use of space in new design
closes #1507 - Improved title/subtitle spacing logic
closes #1497 - Better context for out of bound values
closes #1496 - Always shows current value in header
closes #1235 - Supports SM, may need to add support for #2002
closes #1186 - We still need to improve tick overlapping, see #2236
closes #827 - No longer applies
To discuss
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.tsdark,lightthemes