fix(events): remove async callbacks from code #1730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Working at #1729 leads to an interesting issue regarding the asynchronous callback.
In particular, we were calling the
onChartRendered
andonProjectionAreaChanged
callbacks in a new macro task thanks to arequestAnimationFrame
.The reasons to avoid this way of handling callbacks are:
This PR removes the use of RAF in favor of sync calls.
This solves a side issue in the composable story where the chart render-complete was not called correctly.