fix(events): remove async callbacks from code (#1730)

elastic · Jun 28, 2022 · 27a7256 · 27a7256
1 parent 61de6c2
commit 27a7256
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 19 deletions.
diff --git a/packages/charts/src/chart_types/xy_chart/state/selectors/on_projection_area_caller.ts b/packages/charts/src/chart_types/xy_chart/state/selectors/on_projection_area_caller.ts
@@ -43,9 +43,7 @@ export function createOnProjectionAreaCaller(): (state: GlobalChartState) => voi
             isDiff(prevProps.projection, nextProps.projection) ||
             isDiff(nextProps.parent, nextProps.parent);
           if (onProjectionAreaChange && areDifferent) {
-            requestAnimationFrame(() => {
-              onProjectionAreaChange(nextProps);
-            });
+            onProjectionAreaChange(nextProps);
           }
           prevProps = nextProps;
         },

diff --git a/packages/charts/src/components/chart_container.tsx b/packages/charts/src/components/chart_container.tsx
@@ -151,16 +151,7 @@ class ChartContainerComponent extends React.Component<ReactiveChartProps> {
     const { onMouseUp } = this.props;
 
     window.removeEventListener('mouseup', this.handleBrushEnd);
-
-    requestAnimationFrame(() => {
-      onMouseUp(
-        {
-          x: -1,
-          y: -1,
-        },
-        Date.now(),
-      );
-    });
+    onMouseUp({ x: -1, y: -1 }, Date.now());
   };
 
   render() {

diff --git a/packages/charts/src/components/chart_status.tsx b/packages/charts/src/components/chart_status.tsx
@@ -38,12 +38,7 @@ class ChartStatusComponent extends React.Component<ChartStatusStateProps> {
   }
 
   dispatchRenderChange = () => {
-    const { onRenderChange, rendered } = this.props;
-    if (onRenderChange) {
-      window.requestAnimationFrame(() => {
-        onRenderChange(rendered);
-      });
-    }
+    this.props.onRenderChange?.(this.props.rendered);
   };
 
   render() {