-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(heatmap): compute nice legend items from color scale #1273
Merged
markov00
merged 17 commits into
elastic:master
from
markov00:2021_07_28-heatmap_fix_legend
Aug 16, 2021
+180
−108
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1131677
fix(heatmap): correct legend items
markov00 6640781
Merge branch 'master' into 2021_07_28-heatmap_fix_legend
markov00 8b6fdc9
Merge remote-tracking branch 'upstream/master' into 2021_07_28-heatma…
markov00 487e63f
test: add vrts
markov00 61b1dd2
fix: dedup legend ticks based on formatted labels
markov00 6b4f627
test: update VRT with removed duplicate
markov00 e500773
refactor: cleanup visibility implementation
markov00 0d1053e
refactor: cleanup domain and colors objects codes
markov00 494d41f
refactor: rename color scale ticks to start bands
markov00 a5e571a
Merge branch 'master' into 2021_07_28-heatmap_fix_legend
markov00 4f650bb
Merge branch 'master' into 2021_07_28-heatmap_fix_legend
markov00 f19f14b
fix: replace >= sign and minor fixes
markov00 a70509f
Merge branch 'master' into 2021_07_28-heatmap_fix_legend
markov00 4228efc
refactor: improved code readibility
markov00 53c27fe
Merge branch '2021_07_28-heatmap_fix_legend' of github.com:markov00/e…
markov00 783d463
refactor: refactor band array to colorThresholds
markov00 d113aa3
Merge branch 'master' into 2021_07_28-heatmap_fix_legend
markov00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: rename color scale ticks to start bands
commit 494d41f45c031979f35c47cd22ce6f46a2b00718
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can use a symbol ≥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in f19f14b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic has changed a bit and now every item is GTE the value in the legend
4228efc