fix: replace >= sign and minor fixes

elastic · Aug 11, 2021 · f19f14b · f19f14b
1 parent 4f650bb
commit f19f14b
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 5 deletions.
diff --git a/...ual-tests-for-all-stories-heatmap-alpha-basic-visually-looks-correct-1-snap.png b/...ual-tests-for-all-stories-heatmap-alpha-basic-visually-looks-correct-1-snap.png
diff --git a/...sts-for-all-stories-heatmap-alpha-categorical-visually-looks-correct-1-snap.png b/...sts-for-all-stories-heatmap-alpha-categorical-visually-looks-correct-1-snap.png
diff --git a/...tests/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-linear-1-snap.png b/...tests/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-linear-1-snap.png
diff --git a/...sts/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-quantile-1-snap.png b/...sts/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-quantile-1-snap.png
diff --git a/...sts/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-quantize-1-snap.png b/...sts/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-quantize-1-snap.png
diff --git a/...ts/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-threshold-1-snap.png b/...ts/__image_snapshots__/heatmap-test-ts-heatmap-color-scale-threshold-1-snap.png
diff --git a/packages/charts/src/chart_types/heatmap/state/selectors/compute_legend.ts b/packages/charts/src/chart_types/heatmap/state/selectors/compute_legend.ts
@@ -30,7 +30,7 @@ export const computeLegendSelector = createCustomCachedSelector(
 
       return {
         color,
-        label: `>${i === 0 ? '=' : ''} ${formattedStart}`,
+        label: `${i === 0 ? '≥' : '>'} ${formattedStart}`,
         seriesIdentifiers: [seriesIdentifier],
         isSeriesHidden: deselectedDataSeries.some((dataSeries) => dataSeries.key === seriesIdentifier.key),
         isToggleable: true,

diff --git a/packages/charts/src/chart_types/heatmap/state/selectors/get_color_scale.ts b/packages/charts/src/chart_types/heatmap/state/selectors/get_color_scale.ts
@@ -47,6 +47,7 @@ const SCALE_TYPE_TO_SCALE_FN = {
   [ScaleType.Quantize]: getQuantizedScale,
   [ScaleType.Threshold]: getThresholdScale,
 };
+const DEFAULT_COLOR_SCALE_TYPE = ScaleType.Linear;
 
 /**
  * @internal
@@ -55,7 +56,7 @@ const SCALE_TYPE_TO_SCALE_FN = {
 export const getColorScale = createCustomCachedSelector(
   [getHeatmapSpecSelector, getHeatmapTableSelector],
   (spec, heatmapTable) => {
-    const { scale, bands } = SCALE_TYPE_TO_SCALE_FN[spec.colorScale ?? ScaleType.Linear](spec, heatmapTable);
+    const { scale, bands } = SCALE_TYPE_TO_SCALE_FN[spec.colorScale ?? DEFAULT_COLOR_SCALE_TYPE](spec, heatmapTable);
     return {
       scale,
       bands: dedupBands(bands, spec),

diff --git a/storybook/stories/heatmap/1_basic.tsx b/storybook/stories/heatmap/1_basic.tsx
@@ -78,7 +78,7 @@ export const Example = () => {
     [],
   );
 
-  const logDebugstate = debounce(() => {
+  const logDebugState = debounce(() => {
     if (!debugState) return;
 
     const statusEl = document.querySelector<HTMLDivElement>('.echChartStatus');
@@ -102,9 +102,9 @@ export const Example = () => {
     <Chart>
       <Settings
         onElementClick={onElementClick}
-        onRenderChange={logDebugstate}
+        onRenderChange={logDebugState}
         showLegend
-        legendPosition="top"
+        legendPosition="right"
         onBrushEnd={action('onBrushEnd')}
         brushAxis="both"
         xDomain={{ min: 1572825600000, max: 1572912000000, minInterval: 1800000 }}