Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie chart linked labels are being displayed in cut off way #633

Closed
wylieconlon opened this issue Apr 16, 2020 · 1 comment · Fixed by #670 or elastic/kibana#69126
Closed

Pie chart linked labels are being displayed in cut off way #633

wylieconlon opened this issue Apr 16, 2020 · 1 comment · Fixed by #670 or elastic/kibana#69126
Labels
enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly

Comments

@wylieconlon
Copy link

wylieconlon commented Apr 16, 2020 •
edited by monfera
Loading

Describe the issue
When the horizontal or vertical space to display the linked labels is too small, the labels are getting cut off. This is visible in the "Most basic" sunburst example, since it has long labels that display as linked labels:

Screenshot 2020-04-16 10 52 57

cc @cchaos

Expected behaviour
I would expect one of two things to happen, depending on which is easier:

  1. Labels would always push the main circle smaller to ensure that they are shown (this is what I thought was happening)
  2. If the labels are too long, they would be hidden

I think 1. is my preference for Lens, but maybe there are use cases for 2.

Screenshots
If applicable, add screenshots to help explain your problem.

Version (please complete the following information):
18.3.0
@wylieconlon wylieconlon added bug Something isn't working :partition Partition/PieChart/Donut/Sunburst/Treemap chart related labels Apr 16, 2020
@yizheliu-amazon yizheliu-amazon mentioned this issue Apr 17, 2020
Closed
@wylieconlon wylieconlon mentioned this issue Apr 20, 2020
Open
17 tasks
yizheliu-amazon added a commit to yizheliu-amazon/anomaly-detection-kibana-plugin that referenced this issue May 1, 2020
@yizheliu-amazon
Dones't show link label for sunburst to avoid label cut off. Known bug:
f238259 
elastic/elastic-charts#633
@yizheliu-amazon yizheliu-amazon mentioned this issue May 1, 2020
Merged
yizheliu-amazon added a commit to opendistro-for-elasticsearch/anomaly-detection-kibana-plugin that referenced this issue May 1, 2020
@yizheliu-amazon
Hide link label for sunburst to avoid label cut off.
77e8248 
Known bug: elastic/elastic-charts#633 (#83)
ohltyler pushed a commit to opendistro-for-elasticsearch/anomaly-detection-kibana-plugin that referenced this issue May 1, 2020
@yizheliu-amazon @ohltyler
Hide link label for sunburst to avoid label cut off.
3d855b3 
Known bug: elastic/elastic-charts#633 (#83)
@monfera monfera mentioned this issue May 5, 2020
Merged
4 tasks
@monfera monfera mentioned this issue May 19, 2020
Merged
4 tasks
monfera added a commit that referenced this issue May 19, 2020
@monfera
feat(partition): linked text overflow avoidance (#670)
b6e5911 
Truncates linked labels to avoid horizontal protrusion of text. Removes linked labels that have no remaining label text due to the truncation, or independent of this, which would protrude vertically.

Fix #633
@monfera monfera added enhancement New feature or request and removed bug Something isn't working labels May 19, 2020
markov00 pushed a commit that referenced this issue May 28, 2020
@semantic-release-bot
chore(release): 19.4.0 [skip ci]
bd65244 
# [19.4.0](v19.3.0...v19.4.0) (2020-05-28)

### Bug Fixes

* **partition:** consider legendMaxDepth on legend size ([#654](#654)) ([9429dcf](9429dcf)), closes [#639](#639)

### Features

* **partition:** enable grooves in all group layers ([#666](#666)) ([f5b4767](f5b4767))
* **partition:** linked text overflow avoidance ([#670](#670)) ([b6e5911](b6e5911)), closes [#633](#633)
* **partition:** monotonic font size scaling ([#681](#681)) ([ea2489b](ea2489b)), closes [#661](#661)
* **tooltip:** improve positioning with popperjs ([#651](#651)) ([6512950](6512950)), closes [#596](#596)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 19.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label May 28, 2020
@markov00 markov00 mentioned this issue Jun 15, 2020
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.4.0 [skip ci]
747af29 
# [19.4.0](elastic/elastic-charts@v19.3.0...v19.4.0) (2020-05-28)

### Bug Fixes

* **partition:** consider legendMaxDepth on legend size ([opensearch-project#654](elastic/elastic-charts#654)) ([20cc6ec](elastic/elastic-charts@20cc6ec)), closes [opensearch-project#639](elastic/elastic-charts#639)

### Features

* **partition:** enable grooves in all group layers ([opensearch-project#666](elastic/elastic-charts#666)) ([b1bdfb3](elastic/elastic-charts@b1bdfb3))
* **partition:** linked text overflow avoidance ([opensearch-project#670](elastic/elastic-charts#670)) ([59617db](elastic/elastic-charts@59617db)), closes [opensearch-project#633](elastic/elastic-charts#633)
* **partition:** monotonic font size scaling ([opensearch-project#681](elastic/elastic-charts#681)) ([d46767c](elastic/elastic-charts@d46767c)), closes [opensearch-project#661](elastic/elastic-charts#661)
* **tooltip:** improve positioning with popperjs ([opensearch-project#651](elastic/elastic-charts#651)) ([61d1d9a](elastic/elastic-charts@61d1d9a)), closes [opensearch-project#596](elastic/elastic-charts#596)
hamersu9t added a commit to hamersu9t/anomaly-detection-dashboards-plugin that referenced this issue Aug 10, 2024
@hamersu9t
Hide link label for sunburst to avoid label cut off.
2d571a7 
Known bug: elastic/elastic-charts#633 (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly
Projects
None yet
Milestone
No milestone
3 participants
@wylieconlon @markov00 @monfera