-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump to 1.1 #681
Labels
Comments
kavilla
added
bug
Something isn't working
untriaged
build
Build related additions or modifications
ci
v1.1.0
versioning
and removed
untriaged
labels
Jul 28, 2021
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Aug 16, 2021
Bumps the minor to 1.1 for the 1.0 release. Needed to modify the artifact.js file to the newly formatted artifact URL so that tests work out of the box. Issue resolved: opensearch-project#681 Signed-off-by: Kawika Avilla <[email protected]>
5 tasks
kavilla
added a commit
that referenced
this issue
Aug 18, 2021
Bumps the minor to 1.1 for the 1.0 release. Needed to modify the artifact.js file to the newly formatted artifact URL so that tests work out of the box. Issue resolved: #681 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Aug 18, 2021
Bumps the minor to 1.1 for the 1.0 release. Needed to modify the artifact.js file to the newly formatted artifact URL so that tests work out of the box. Issue resolved: opensearch-project#681 Backport PR: opensearch-project#722 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this issue
Aug 20, 2021
Bumps the minor to 1.1 for the 1.0 release. Needed to modify the artifact.js file to the newly formatted artifact URL so that tests work out of the box. Issue resolved: #681 Backport PR: #722 Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the issue
Normally I would not have created an issue for version increments but we are currently blocked. We need to update the semantic versioning of OpenSearch Dashboards on the
main
and1.x
branch. However, we run into issues with automation if we currently modify package.json to be 1.1 because a nightly artifact of OpenSearch Engines is not being built. Why is this a problem? Because when running some integration tests and functional tests it will try to pull down the OpenSearch artifact based on the same version of Dashboards by default. But it will 404 if the artifact doesn't exist.To Reproduce
yarn test:ftr
Expected behavior
Tests should work out of the box.
OpenSearch Version
n/a
Dashboards Version
1.1
Plugins
n/a
Additional context
We will need to constantly modify the version number. So not only branches of the Engines repo can be built. If the main branch gets modified with the next version then an artifact will need to be built and published, otherwise the Dashboards repo is blocked from bumping the version number.
Also the url of the artifacts should stay the same with the variance in RC and GA. The code was made to handle the difference but if the URLs or how we change the naming scheme then we need to update the code.
The text was updated successfully, but these errors were encountered: