Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix spec naming #412

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

nickofthyme
Copy link
Collaborator

Summary

set name to spec name then spec id

name is a global variable in ts and thus was not caught in the typecheck

closes #411

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

set name to spec name then spec id

closes elastic#411
@nickofthyme nickofthyme requested a review from markov00 October 9, 2019 00:17
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #412 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #412   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          39     39           
  Lines        2853   2853           
  Branches      681    664   -17     
=====================================
  Hits         2796   2796           
  Misses         50     50           
  Partials        7      7
Impacted Files Coverage Δ
src/chart_types/xy_chart/tooltip/tooltip.ts 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bac09...a9d047b. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme nickofthyme merged commit 3690cca into elastic:master Oct 9, 2019
markov00 pushed a commit that referenced this pull request Oct 9, 2019
## [13.4.1](v13.4.0...v13.4.1) (2019-10-09)

### Bug Fixes

* **tooltip:** fix spec naming ([#412](#412)) ([3690cca](3690cca)), closes [#411](#411)
@markov00
Copy link
Member

markov00 commented Oct 9, 2019

🎉 This PR is included in version 13.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 9, 2019
@nickofthyme nickofthyme deleted the fix/spec-naming branch October 9, 2019 13:51
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip shows specId instead of name prop
3 participants