Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip shows specId instead of name prop #411

Closed
2 tasks done
markov00 opened this issue Oct 8, 2019 · 1 comment · Fixed by #412
Closed
2 tasks done

Tooltip shows specId instead of name prop #411

markov00 opened this issue Oct 8, 2019 · 1 comment · Fixed by #412
Assignees
@nickofthyme
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart regression released Issue released publicly :tooltip Related to hover tooltip

Comments

@markov00
Copy link
Member

markov00 commented Oct 8, 2019

Describe the bug
The tooltip shows the specId value instead of the name if specified.

To Reproduce
Steps to reproduce the behavior:

  1. Create a simple Chart
  2. Add a name prop to the series different from the specId
  3. Look at the tooltip, it will show the specId instead of the name

Expected behavior
The name property, if exist, should take precedence on the specId

Screenshots

Version (please complete the following information):

  • OS: all
  • Browser: all
  • Elastic Charts: 13.4.0/master

Additional context
Regression
5c35a4d#diff-551c93b1f051b0ef3056c7f06c477471R48-R58

Errors in browser console
n/a

Kibana Cross Issues

elastic/kibana#47612

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :tooltip Related to hover tooltip regression labels Oct 8, 2019
This was referenced Oct 8, 2019
Closed
Closed
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Oct 9, 2019
@nickofthyme
fix(tooltip): fix spec naming
a9d047b 
set name to spec name then spec id

closes elastic#411
@nickofthyme nickofthyme mentioned this issue Oct 9, 2019
Merged
5 tasks
nickofthyme added a commit that referenced this issue Oct 9, 2019
@nickofthyme
fix(tooltip): fix spec naming (#412)
3690cca 
set name to spec name then spec id

closes #411
markov00 pushed a commit that referenced this issue Oct 9, 2019
@semantic-release-bot
chore(release): 13.4.1 [skip ci]
3b37328 
## [13.4.1](v13.4.0...v13.4.1) (2019-10-09)

### Bug Fixes

* **tooltip:** fix spec naming ([#412](#412)) ([3690cca](3690cca)), closes [#411](#411)
@markov00
Copy link
Member Author

markov00 commented Oct 9, 2019

🎉 This issue has been resolved in version 13.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 9, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 13.4.1 [skip ci]
bf0b3ef 
## [13.4.1](elastic/elastic-charts@v13.4.0...v13.4.1) (2019-10-09)

### Bug Fixes

* **tooltip:** fix spec naming ([opensearch-project#412](elastic/elastic-charts#412)) ([01758fa](elastic/elastic-charts@01758fa)), closes [opensearch-project#411](elastic/elastic-charts#411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart regression released Issue released publicly :tooltip Related to hover tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tooltip): fix spec naming nickofthyme/elastic-charts
2 participants
@markov00 @nickofthyme