fix(tooltip): fix spec naming (#412)

set name to spec name then spec id closes #411
elastic · Oct 9, 2019 · 3690cca · 3690cca
1 parent 81bac09
commit 3690cca
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/chart_types/xy_chart/tooltip/tooltip.test.ts b/src/chart_types/xy_chart/tooltip/tooltip.test.ts
@@ -95,6 +95,15 @@ describe('Tooltip formatting', () => {
     expect(tooltipValue.color).toBe('blue');
     expect(tooltipValue.value).toBe('10');
   });
+  it('should set name as spec name when provided', () => {
+    const name = 'test - spec';
+    const tooltipValue = formatTooltip(indexedBandedGeometry, { ...SPEC_1, name }, false, false, YAXIS_SPEC);
+    expect(tooltipValue.name).toBe(name);
+  });
+  it('should set name as spec id when name is not provided', () => {
+    const tooltipValue = formatTooltip(indexedBandedGeometry, SPEC_1, false, false, YAXIS_SPEC);
+    expect(tooltipValue.name).toBe(SPEC_1.id);
+  });
   test('format banded tooltip - upper', () => {
     const tooltipValue = formatTooltip(indexedBandedGeometry, bandedSpec, false, false, YAXIS_SPEC);
     expect(tooltipValue.name).toBe('bar_1 - upper');

diff --git a/src/chart_types/xy_chart/tooltip/tooltip.ts b/src/chart_types/xy_chart/tooltip/tooltip.ts
@@ -55,7 +55,7 @@ export function formatTooltip(
   if (seriesKey.length > 0) {
     displayName = seriesKey.join(' - ');
   } else {
-    displayName = name || `${spec.id}`;
+    displayName = spec.name || `${spec.id}`;
   }
 
   if (isBandedSpec(spec.y0Accessors) && (isAreaSeriesSpec(spec) || isBarSeriesSpec(spec))) {