-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chart size type overrides #317
Conversation
Now the Chart size prop takes multiple types as input: basic string or number, a tuple of string or number or undefined, an object with width and height (string, number or optionals). fix elastic#177
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=========================================
+ Coverage 98.04% 98.1% +0.06%
=========================================
Files 37 38 +1
Lines 2715 2855 +140
Branches 636 692 +56
=========================================
+ Hits 2662 2801 +139
Misses 48 48
- Partials 5 6 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion
🎉 This PR is included in version 9.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [9.2.0](elastic/elastic-charts@v9.1.1...v9.2.0) (2019-08-19) ### Bug Fixes * reduce opacity for points when hovering over legend items ([opensearch-project#322](elastic/elastic-charts#322)) ([cc9e45f](elastic/elastic-charts@cc9e45f)), closes [opensearch-project#291](elastic/elastic-charts#291) ### Features * add chart size type overrides ([opensearch-project#317](elastic/elastic-charts#317)) ([8d43aa9](elastic/elastic-charts@8d43aa9)), closes [opensearch-project#177](elastic/elastic-charts#177)
Summary
fix #177
Add multiple override types for
<Chart>
size
props.The
size
parameters now acceptChartSize
:The default value for an
undefined
parameter is100%
.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts
(and stories only import from../src
except for test data & storybook)