Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovering over series in legend for LineSeries' doesn't reduce opacity of dot of other series #291

Open
cchaos opened this issue Aug 6, 2019 · 2 comments · Fixed by #322
Open

Hovering over series in legend for LineSeries' doesn't reduce opacity of dot of other series #291

cchaos opened this issue Aug 6, 2019 · 2 comments · Fixed by #322
Labels
bug Something isn't working good first issue Good for newcomers Impact:Medium :interactions Interactions related issue :legend Legend related issue :xy Bar/Line/Area chart related

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 6, 2019

Describe the bug
When mousing over the legend the currently hovered series stays at full opacity while the other series reduce opacity. However when the non-hovered series is a LineSeries, only the line's opacity reduces, the dot stays at full opacity.

To Reproduce
Steps to reproduce the behavior:

  1. Create a chart with several LineSeries
  2. Hover legend

Expected behavior
The dot and the line should be grouped and then whole group's opacity should be reduced

Screenshots

Version (please complete the following information):

  • Elastic Charts: 8.1.5
@cchaos cchaos added bug Something isn't working :interactions Interactions related issue :legend Legend related issue labels Aug 6, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Aug 16, 2019
@markov00
fix: reduce opacity for points when hovering over legend items
bf53ac5 
This commit reduce the opacity of points in areas and lines series when hovering over a series in
the legend

fix elastic#291
@markov00 markov00 mentioned this issue Aug 16, 2019
Merged
5 tasks
markov00 added a commit that referenced this issue Aug 19, 2019
@markov00
fix: reduce opacity for points when hovering over legend items (#322)
196341b 
This commit reduce the opacity of points in areas and lines series when hovering over a series in the legend

fix #291
markov00 pushed a commit that referenced this issue Aug 19, 2019
@semantic-release-bot
chore(release): 9.2.0 [skip ci]
577a034 
# [9.2.0](v9.1.1...v9.2.0) (2019-08-19)

### Bug Fixes

* reduce opacity for points when hovering over legend items ([#322](#322)) ([196341b](196341b)), closes [#291](#291)

### Features

* add chart size type overrides ([#317](#317)) ([b8dc9e1](b8dc9e1)), closes [#177](#177)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 9.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 19, 2019
@cchaos
Copy link
Contributor Author

cchaos commented Aug 19, 2019

@markov00 Thanks for tackling this one so quickly. However, I think there's still an issue of grouping the line with the dot. When the dot becomes transparent you can see the line behind it and the graph starts to become very noisy.

So in the example from your PR, it should actually be:

@cchaos cchaos reopened this Aug 19, 2019
@markov00 markov00 added the :xy Bar/Line/Area chart related label Mar 26, 2020
@nickofthyme nickofthyme added the good first issue Good for newcomers label Jun 7, 2021
@markov00 markov00 added Impact:Medium and removed released Issue released publicly labels Jul 28, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 9.2.0 [skip ci]
3439c69 
# [9.2.0](elastic/elastic-charts@v9.1.1...v9.2.0) (2019-08-19)

### Bug Fixes

* reduce opacity for points when hovering over legend items ([opensearch-project#322](elastic/elastic-charts#322)) ([cc9e45f](elastic/elastic-charts@cc9e45f)), closes [opensearch-project#291](elastic/elastic-charts#291)

### Features

* add chart size type overrides ([opensearch-project#317](elastic/elastic-charts#317)) ([8d43aa9](elastic/elastic-charts@8d43aa9)), closes [opensearch-project#177](elastic/elastic-charts#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Impact:Medium :interactions Interactions related issue :legend Legend related issue :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reduce opacity for points when hovering over legend items markov00/elastic-charts
3 participants
@cchaos @markov00 @nickofthyme