Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] eslint running #177

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 17, 2021

Signed-off-by: Kawika Avilla [email protected]

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
Copy link
Member Author

kavilla commented Mar 17, 2021

I know we haven't touched this package but without changing this eslint wouldn't run.

@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kavilla kavilla merged commit e0fa8d0 into opensearch-project:dashboards Mar 17, 2021
@kavilla kavilla deleted the linter-running branch March 18, 2021 07:55
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <[email protected]>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <[email protected]>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
…ributes (opensearch-project#163) (opensearch-project#177)

* feat: skip permission validate when saved object without workspaces and permissions attributes



* feat: add annontation to skip permission check



* refactor: remove bind and simplify validate logic



* feat: remove library write for object based ACL



---------


(cherry picked from commit cfa9c4b)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants