Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gridLineStyle to be part of Theme #237

Closed
1 task done
cchaos opened this issue Jun 12, 2019 · 1 comment · Fixed by #257
Closed
1 task done

Move gridLineStyle to be part of Theme #237

cchaos opened this issue Jun 12, 2019 · 1 comment · Fixed by #257
Assignees
@rshen91
Labels
enhancement New feature or request released Issue released publicly :styling Styling related issue

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 12, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
At the moment, you have to declare your grid styles completely separate from the theme, which also makes dark vs light mode more complicated.

Describe the solution you'd like
Move gridLineStyle into the full Theme json object.

Checklist

  • this request is checked against already exist requests
  • [ ] every related Kibana issue is listed under Kibana Cross Issues list
  • [ ] kibana cross issue tag is associated to the issue if any kibana cross issue is present
@cchaos cchaos added enhancement New feature or request :styling Styling related issue labels Jun 12, 2019
@rshen91 rshen91 mentioned this issue Jul 2, 2019
Merged
5 tasks
nickofthyme pushed a commit that referenced this issue Sep 11, 2019
@rshen91 @nickofthyme
feat(theme): add gridLineStyle to AxisConfig (#257)
97dd812 
Move gridLineStyle into the `Theme` interface through the `AxisConfig` interface.

BREAKING CHANGE: Added `GridLineStyle` to `Theme` (`theme.gridLineStyle.horizontal` and `theme.gridLineStyle.vertical`)

* add gridLineStyle to AxisConfig
* add chartTheme vs axisSpec
* add gridLineStyle for theme or spec
* merge gridLineConfig from theme with axisSpec
* add visible key to GridLineConfig
* specify theme styling per axis in story
* add gridLineStyle theme with horiz and vert

Fixes #237
markov00 pushed a commit that referenced this issue Sep 11, 2019
@semantic-release-bot
chore(release): 12.0.0 [skip ci]
db54398 
# [12.0.0](v11.2.0...v12.0.0) (2019-09-11)

### Features

* **theme:** add gridLineStyle to AxisConfig ([#257](#257)) ([97dd812](97dd812)), closes [#237](#237)

### BREAKING CHANGES

* **theme:** Added `GridLineStyle` to `Theme` (`theme.gridLineStyle.horizontal` and `theme.gridLineStyle.vertical`)

* add gridLineStyle to AxisConfig
* add chartTheme vs axisSpec
* add gridLineStyle for theme or spec
* merge gridLineConfig from theme with axisSpec
* add visible key to GridLineConfig
* specify theme styling per axis in story
* add gridLineStyle theme with horiz and vert
@markov00
Copy link
Member

🎉 This issue has been resolved in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 11, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 12.0.0 [skip ci]
77ccd62 
# [12.0.0](elastic/elastic-charts@v11.2.0...v12.0.0) (2019-09-11)

### Features

* **theme:** add gridLineStyle to AxisConfig ([opensearch-project#257](elastic/elastic-charts#257)) ([bf0f37f](elastic/elastic-charts@bf0f37f)), closes [opensearch-project#237](elastic/elastic-charts#237)

### BREAKING CHANGES

* **theme:** Added `GridLineStyle` to `Theme` (`theme.gridLineStyle.horizontal` and `theme.gridLineStyle.vertical`)

* add gridLineStyle to AxisConfig
* add chartTheme vs axisSpec
* add gridLineStyle for theme or spec
* merge gridLineConfig from theme with axisSpec
* add visible key to GridLineConfig
* specify theme styling per axis in story
* add gridLineStyle theme with horiz and vert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
enhancement New feature or request released Issue released publicly :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theme): add gridLineStyle to AxisConfig rshen91/elastic-charts
3 participants
@cchaos @markov00 @rshen91