Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line appears across the chart after v.3.4.5 #140

Closed
2 tasks
sulemanof opened this issue Apr 1, 2019 · 1 comment · Fixed by #141
Closed
2 tasks

Line appears across the chart after v.3.4.5 #140

sulemanof opened this issue Apr 1, 2019 · 1 comment · Fixed by #141
Assignees
@markov00
Labels
bug Something isn't working released Issue released publicly

Comments

@sulemanof
Copy link

Describe the bug
An extra line appears on an area chart.
The issue reproducible in the storybook

Expected behavior
The issue wasn't reproducible in 3.4.4 and earlier

Screenshots
If applicable, add screenshots to help explain your problem.
image

Version (please complete the following information):

  • Elastic Charts: 3.4.5

Additional context
Add any other context about the problem here.

Errors in browser console
If applicable, add any console error.

Kibana Cross Issues
Add any Kibana related issues here.

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@sulemanof sulemanof added the bug Something isn't working label Apr 1, 2019
@markov00 markov00 self-assigned this Apr 1, 2019
@markov00 markov00 added this to the 7.1 milestone Apr 1, 2019
@markov00 markov00 mentioned this issue Apr 1, 2019
Merged
4 tasks
markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 1, 2019
@markov00
fix(areacharts): fix misaligned rendering props
99e9482 
There was a misalignment between the animated props and the non animated ones that causes the area
line to use the fill instead of stroke wrongly rendering the line on the chart.

fix elastic#140
markov00 added a commit that referenced this issue Apr 1, 2019
@markov00
fix(areachart): fix misaligned rendering props (#141)
9694b5b 
There was a misalignment between the animated props and the non animated ones that causes the area line to use the fill instead of stroke wrongly rendering the line on the chart. We also aligned the animated and not animated props for line and bars. 
React Spring also distributes ES6 by default, which breaks jest tests unless it's imported explicitly
using the cjs extension. see pmndrs/react-spring#555

fix #140
markov00 pushed a commit that referenced this issue Apr 1, 2019
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
a548484 
# [3.5.0](v3.4.5...v3.5.0) (2019-04-01)

### Bug Fixes

* **areachart:** fix misaligned rendering props  ([#141](#141)) ([9694b5b](9694b5b)), closes [#140](#140)

### Features

* **specs:** add name to series specs ([#142](#142)) ([a6e6f49](a6e6f49)), closes [#136](#136)
@markov00
Copy link
Member

markov00 commented Apr 1, 2019

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 1, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
f802240 
# [3.5.0](elastic/elastic-charts@v3.4.5...v3.5.0) (2019-04-01)

### Bug Fixes

* **areachart:** fix misaligned rendering props  ([opensearch-project#141](elastic/elastic-charts#141)) ([d627f4d](elastic/elastic-charts@d627f4d)), closes [opensearch-project#140](elastic/elastic-charts#140)

### Features

* **specs:** add name to series specs ([opensearch-project#142](elastic/elastic-charts#142)) ([c045eee](elastic/elastic-charts@c045eee)), closes [opensearch-project#136](elastic/elastic-charts#136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(areachart): fix misaligned rendering props markov00/elastic-charts
2 participants
@markov00 @sulemanof