Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding a single series from the legend results in a wrong visualization #102

Closed
2 tasks done
markov00 opened this issue Mar 19, 2019 · 1 comment · Fixed by #219
Closed
2 tasks done

Hiding a single series from the legend results in a wrong visualization #102

markov00 opened this issue Mar 19, 2019 · 1 comment · Fixed by #219
Assignees
@rshen91
Labels
bug Something isn't working :interactions Interactions related issue :legend Legend related issue released Issue released publicly

Comments

@markov00
Copy link
Member

Describe the bug
When you have a single series chart with legend, clicking on the eye to hide the series results in a wrongly represented chart as shown in screenshot

To Reproduce
Steps to reproduce the behavior:

  1. Go to Bar Chart with axis and legend story
  2. Click on the eye on the legend
  3. See error

Expected behavior
We can add a clear message displaying something like: no data to show as in the EuiSeriesChart or we can disable any hide/show eye if we have one single series on the chart.

Screenshots
Screenshot 2019-03-19 at 16 02 11

Version (please complete the following information):

  • OS: Mac OS 10.14.3
  • Browser: chrome
  • Elastic Charts: 3.1.1/master

Additional context
n/a

Errors in browser console

Konva warning: "points" attribute has non numeric element Infinity. Make sure that all elements are numbers.
Konva warning: Infinity is a not valid value for "x" attribute. The value should be a number.

Kibana Cross Issues
n/a

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added bug Something isn't working :interactions Interactions related issue :legend Legend related issue labels Mar 19, 2019
@rshen91 rshen91 mentioned this issue May 28, 2019
Merged
3 tasks
rshen91 added a commit that referenced this issue Jul 22, 2019
@rshen91
feat: display empty chart status when no series is selected
f1505df 
Closes #102
markov00 pushed a commit that referenced this issue Jul 22, 2019
@semantic-release-bot
chore(release): 8.1.0 [skip ci]
f196560 
# [8.1.0](v8.0.2...v8.1.0) (2019-07-22)

### Features

* display empty chart status when no series is selected  ([f1505df](f1505df)), closes [#102](#102)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 22, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 8.1.0 [skip ci]
d4728f9 
# [8.1.0](elastic/elastic-charts@v8.0.2...v8.1.0) (2019-07-22)

### Features

* display empty chart status when no series is selected  ([57cfc5e](elastic/elastic-charts@57cfc5e)), closes [opensearch-project#102](elastic/elastic-charts#102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
bug Something isn't working :interactions Interactions related issue :legend Legend related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add isChartEmpty rshen91/elastic-charts
2 participants
@markov00 @rshen91