Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kibana utils #102

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 8, 2021

Issue #, if available:
#37

Description of changes:
Rename folders, files, variables to opensearch_dashboards_utils.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kavilla kavilla requested review from mihirsoni and boktorbb March 8, 2021 17:26
@kavilla kavilla changed the base branch from main to dashboards March 8, 2021 17:26
@@ -1,11 +1,11 @@
## API Report File for "kibana"
## API Report File for "opensearch-dashboards"
Copy link
Contributor

@mihirsoni mihirsoni Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave autogenerated file as is and regenerate ?

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks for the changes.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit 13245d8 into opensearch-project:dashboards Mar 11, 2021
@kavilla kavilla deleted the rename-kibana-utils branch March 18, 2021 08:05
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
kavilla added a commit that referenced this pull request Mar 20, 2021
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 28, 2023
* feat: add some flag

Signed-off-by: SuZhou-Joe <[email protected]>

* refractor: add enabled$ in server side

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add logic check in public side

Signed-off-by: SuZhou-Joe <[email protected]>

* feature: remove useless property

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some modify

* feat: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 6, 2023
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
* feat: add some flag

Signed-off-by: SuZhou-Joe <[email protected]>

* refractor: add enabled$ in server side

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add logic check in public side

Signed-off-by: SuZhou-Joe <[email protected]>

* feature: remove useless property

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some modify

* feat: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
* feat: add some flag

Signed-off-by: SuZhou-Joe <[email protected]>

* refractor: add enabled$ in server side

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add logic check in public side

Signed-off-by: SuZhou-Joe <[email protected]>

* feature: remove useless property

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some modify

* feat: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants