Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade under V2 #1779

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Fix upgrade under V2 #1779

merged 1 commit into from
Nov 24, 2022

Conversation

belimawr
Copy link
Contributor

What does this PR do?

Fix a typo that was preventing upgrades under V2.

Why is it important?

It fixes the upgrade process for versions >= 8.6.0

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Author's Checklist

How to test this PR locally

  1. Build the 8.6 branch (it will build the version 8.6.0)
  2. Build the main branch (it will build the version 8.7.0)
  3. Get a Elastic-Stack up and running with Fleet server
  4. Install the Elastic-Agent v8.6.0
  5. Ensure it is healthy
  6. Stop the Elastic-Agent
  7. Edit it's elastic-agent.yml and add the dropPath settings:
    agent.download:
      dropPath: /home/vagrant/dropPath
  8. Restart the Elastic-Agent
  9. Run the upgrade command as root (just to be on the safe side, also export the dropPath env var):
    AGENT_DROP_PATH=/home/vagrant/dropPath/ ./elastic-agent upgrade  8.7.0  -v -e -d "*"
    
  10. Ensure the new version (v8.7.0) is installed by running elastic-agent status

Caveats

## Related issues
## Use cases
## Screenshots
## Logs

@belimawr belimawr requested a review from a team as a code owner November 23, 2022 20:43
@belimawr belimawr requested review from AndersonQ and aleksmaus and removed request for a team November 23, 2022 20:43
@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2022

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@belimawr belimawr added backport-v8.6.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-24T09:15:38.507+0000

  • Duration: 18 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 4517
Skipped 13
Total 4530

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify mergify bot removed the backport-skip label Nov 23, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 23, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.305% (58/59) 👍
Files 71.066% (140/197) 👍
Classes 70.557% (266/377) 👍
Methods 54.828% (795/1450) 👍
Lines 40.341% (8595/21306) 👍
Conditionals 100.0% (0/0) 💚

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even a one line fix, but one character fix. It could not get simpler.

Thanks for catching this and averting a future disaster.

Fix a typo that was preventing upgrades under V2.
@belimawr belimawr merged commit ef8730a into elastic:main Nov 24, 2022
@belimawr belimawr deleted the fix-upgrade branch November 24, 2022 09:46
mergify bot pushed a commit that referenced this pull request Nov 24, 2022
Fix a typo that was preventing upgrades under V2.

(cherry picked from commit ef8730a)
belimawr added a commit that referenced this pull request Nov 28, 2022
Fix a typo that was preventing upgrades under V2.

(cherry picked from commit ef8730a)

Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.6.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants