Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration and unit test coverage for the Elastic agent upgrade process. #1359

Closed
5 tasks
cmacknz opened this issue Sep 29, 2022 · 3 comments
Closed
5 tasks
Assignees
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team technical debt

Comments

@cmacknz
Copy link
Member

cmacknz commented Sep 29, 2022

We currently rely on manual testing and end to end testing to find problems with the agent upgrade process. The feedback loop during develop from these tests is too slow, and they do not adequately test the various upgrade failure modes the agent can encounter in the field. Add a set of automated upgrade tests local to the agent repository that:

  • Tests that the normal upgrade process can proceed without issues.
  • Tests that the upgrade process can successfully roll back to the previous version when the newly installed agent version fails to start.
  • Tests that the agent reliably restarts with the current version when an upgrade to a new version is interrupted unexpectedly.
  • Tests that the upgrade process can detect corrupted or unsigned upgrade packages.
  • Tests that the upgrade process either detects or automatically recovers from corrupted agent installations (missing directories, symlinks, files, etc.).

For reference the majority of the upgrade process is defined in https://github.com/elastic/elastic-agent/tree/main/internal/pkg/agent/application/upgrade.

@amitkanfer
Copy link
Contributor

@pierrehilbert i've changed the priority of this one to P0

@pierrehilbert
Copy link
Contributor

Part of it is already started by @blakerouse here: #2176

@pierrehilbert
Copy link
Contributor

Closing to have only one issue for upgrades: #2176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team technical debt
Projects
None yet
Development

No branches or pull requests

6 participants