Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkite: add test on macos #112

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Buildkite: add test on macos #112

merged 5 commits into from
Nov 16, 2023

Conversation

leo-ri
Copy link
Contributor

@leo-ri leo-ri commented Nov 16, 2023 •
edited
Loading

What does this PR do? Why is it important?

to complete migration to BK (Jenkins job had tests on macos)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Related issues

windows and MacOS are failing: #109

@leo-ri leo-ri marked this pull request as ready for review November 16, 2023 11:34
@leo-ri leo-ri requested a review from a team as a code owner November 16, 2023 11:34
@leo-ri leo-ri requested review from belimawr and removed request for a team November 16, 2023 11:34
@leo-ri leo-ri merged commit c117bd8 into elastic:main Nov 16, 2023
2 checks passed
@belimawr belimawr mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@belimawr belimawr belimawr approved these changes

@pazone pazone Awaiting requested review from pazone

@mrodm mrodm Awaiting requested review from mrodm

@alexsapran alexsapran Awaiting requested review from alexsapran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo-ri @belimawr @jlind23