-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run unit-tests on CI and block PRs if tests fails #110
Comments
Just added |
We still need to enable running tests in MacOS, we could re-open this issue or create a new one, either way is fine for me. I'm a BuildKite expert, but based on the pipeline definition I don't see the tests running on Windows: elastic-agent-system-metrics/.buildkite/pipeline.yml Lines 18 to 33 in 74354aa
|
@belimawr open a new issue specifically for the additional platform support. |
It seems unit tests are not properly running on CI, recently we found a bug that would be caught by just running
go test ./...
on all supported OSes.Ex: #109
Our BuildKite pipeline is only defining Linux and Windows machines, it should also define MacOS.
It also seems the BuildKite tests that do run are not preventing PRs from being merged. #103 did introduce an issue that caused the CI build to fail: https://buildkite.com/elastic/elastic-agent-system-metrics/builds/112#018bb435-2721-46d1-924b-d46b0bae356d, however this is not seen from the PR.
The text was updated successfully, but these errors were encountered: