Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hints helpers under utils and add tests #20

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Move hints helpers under utils and add tests #20

merged 2 commits into from
Jun 28, 2022

Conversation

ChrsMark
Copy link
Member

Follow up of #19 since it fits better under the utils because it's not kubernetes specific. Also transferring the tests from Beats.

@ChrsMark ChrsMark added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Jun 28, 2022
@ChrsMark ChrsMark requested a review from gizas June 28, 2022 09:42
@ChrsMark ChrsMark requested a review from a team as a code owner June 28, 2022 09:42
@ChrsMark ChrsMark self-assigned this Jun 28, 2022
@ChrsMark ChrsMark requested review from belimawr and faec and removed request for a team June 28, 2022 09:42
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-28T09:58:17.958+0000

  • Duration: 11 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 219
Skipped 0
Total 219

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ChrsMark
Fix linter
ac0cd3d 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark merged commit 1e1562b into elastic:main Jun 28, 2022
@ChrsMark ChrsMark mentioned this pull request Jun 28, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizas gizas gizas approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@ChrsMark ChrsMark

Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @elasticmachine @gizas