Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external autodiscover library for hints helpers #32132

Merged
merged 12 commits into from
Jun 30, 2022

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jun 28, 2022

What does this PR do?

Make use of the external github.com/elastic/elastic-agent-autodiscover/utils library to replace local implementation of hints' helpers.

Hints helpers were move to the external library with elastic/elastic-agent-autodiscover#19 and elastic/elastic-agent-autodiscover#20

Why is it important?

With this transition the external library is the single source of truth and will be used by Beats and Elastic-Agent from now on whenever possible.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Ci checks should be enough

Related issues

@ChrsMark ChrsMark added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Jun 28, 2022
@ChrsMark ChrsMark requested a review from a team June 28, 2022 14:01
@ChrsMark ChrsMark requested review from a team as code owners June 28, 2022 14:01
@ChrsMark ChrsMark self-assigned this Jun 28, 2022
@ChrsMark ChrsMark requested review from belimawr and kvch and removed request for a team June 28, 2022 14:01
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update_autodiscover_lib upstream/update_autodiscover_lib
git merge upstream/main
git push upstream update_autodiscover_lib

@ChrsMark ChrsMark force-pushed the update_autodiscover_lib branch from de615aa to 723cdb6 Compare June 28, 2022 14:09
@ChrsMark ChrsMark requested a review from a team as a code owner June 28, 2022 14:09
ChrsMark added 2 commits June 28, 2022 17:24
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-29T11:07:10.830+0000

  • Duration: 137 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 22390
Skipped 1937
Total 24327

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except those lint errors looks good!

ChrsMark added 3 commits June 29, 2022 08:45
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark requested a review from a team as a code owner June 29, 2022 10:00
ChrsMark added 6 commits June 29, 2022 13:15
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Copy link
Member Author

E2E tests' failures seem irrelevant. Merging this one.

@ChrsMark ChrsMark merged commit edcba33 into elastic:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants