-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use external autodiscover library for hints helpers #32132
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
Signed-off-by: chrismark <[email protected]>
de615aa
to
723cdb6
Compare
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except those lint errors looks good!
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
E2E tests' failures seem irrelevant. Merging this one. |
What does this PR do?
Make use of the external
github.com/elastic/elastic-agent-autodiscover/utils
library to replace local implementation of hints' helpers.Hints helpers were move to the external library with elastic/elastic-agent-autodiscover#19 and elastic/elastic-agent-autodiscover#20
Why is it important?
With this transition the external library is the single source of truth and will be used by Beats and Elastic-Agent from now on whenever possible.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Ci checks should be enough
Related issues