-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename hostname to host.name fields to be consistent #74
Conversation
`destination.hostname`, `device.hostname` and `source.hostname` were renamed to `*.host.name` to be consitent with the host object.
LGTM |
@webmat If ok for, best squash directly. |
@ruflin I think "hostname" is a better ECS name for this field, as we are looking to populate this with the internet hostname which is commonly known as "hostname." See wikipedia hostname. This too would preserve a consistent use of "hostname" in Also, in case we decide to keep Finally, this also allows us to continue to have only one dot in our commonly used "ECS-compatible" fields, an original ECS goal to assist with ease-of-recall and predictability. I vote for no further changes from |
Renaming |
Yeah I think I'm also in favor of sticking with the widely used naming, in cases like this. |
As discussed, we're closing this and we'll be sticking with |
Would be good to add here a comment with reasoning so if we get back to it we know why. |
destination.hostname
,device.hostname
andsource.hostname
were renamed to*.host.name
to be consitent with the host object.Related to #62