Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making of all objects reusable #72

Closed
vbohata opened this issue Aug 9, 2018 · 3 comments
Closed

Making of all objects reusable #72

vbohata opened this issue Aug 9, 2018 · 3 comments
Labels

Comments

@vbohata
Copy link

vbohata commented Aug 9, 2018

I have seen a lot of use cases to use host and other objects inside the another ones. Also mentioned in couple of issues here). I think all or almost all objects should be designed to be reusable. Just now I found another field name which could cause a collision in the future:

user_agent.device, .. vs. device object. In user_agent the device is keyword, but should be renamed to user_agent.device.name or user_agent.device_name, so everyone could put device fields inside user_agent. Maybe not the best example with user_agent but if anybody see device, it should be related to device.* object. Like host.name vs hostname ...

If not possible in all cases the documentation should clearly mention it. For each field group there should be info if it is mentioned to be only top level or reusable in any level.

@ruflin
Copy link
Member

ruflin commented Aug 10, 2018

++ on what you wrote above. The same name should always have the same meaning and properties. I think #62 is the same issue and I opened a PR for this here: #74 Do you want to open a PR for the device issue? Any other items you see where we need a change?

Would be good to get your feedback on #71

@vbohata
Copy link
Author

vbohata commented Aug 10, 2018

Yes, open a PR for the device please. At this time I do not see any items needing a change (as you wrote a PR for host has already been opened).
I also added feedback to the issue you mentioned.

@ruflin
Copy link
Member

ruflin commented Nov 5, 2018

We now defined the ones that are reusable. Please open a PR if you think some more should be reusable.

@ruflin ruflin closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants