Index user_agent.original, after all.
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
approved these changes
Dec 10, 2018
3 tasks
webmat
added a commit
to elastic/beats
that referenced
this pull request
Dec 21, 2018
This addresses most of the differences, with the exception of http (#9645) and os (PR coming) Changes: - `client/server`, `source/destination` - Update each field set's definition - Add the `.address` field (except for `source`, which already had it) - `network`: update definitions and examples wrt lowercase directive - `user_agent.original` index is now `keyword` indexed (See elastic/ecs#262) - Update `ecs.version` example
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
This addresses most of the differences, with the exception of http (elastic#9645) and os (PR coming) Changes: - `client/server`, `source/destination` - Update each field set's definition - Add the `.address` field (except for `source`, which already had it) - `network`: update definitions and examples wrt lowercase directive - `user_agent.original` index is now `keyword` indexed (See elastic/ecs#262) - Update `ecs.version` example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussions on PR #240, me and @ruflin synced up and agreed that indexing the
user_agent.originalwould actually be useful (as opposed toevent.originalandlog.original).