-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish importing ECS Beta 2 differences #9738
Conversation
@andrewkroh I'm having problems with Anyway, here's the result of one of my runs:
|
@webmat Try running |
@ruflin Ah, that did it. Thanks! |
103faed
to
619c5a0
Compare
- With the exception of http, captured in elastic#9645 - With the exception of os, which must be updated in a bunch of places
619c5a0
to
34c31dd
Compare
This addresses most of the differences, with the exception of http (elastic#9645) and os (PR coming) Changes: - `client/server`, `source/destination` - Update each field set's definition - Add the `.address` field (except for `source`, which already had it) - `network`: update definitions and examples wrt lowercase directive - `user_agent.original` index is now `keyword` indexed (See elastic/ecs#262) - Update `ecs.version` example
This PR doesn't address the updates to HTTP, which are updated by #9645.
Changes:
client/server
,source/destination
.address
field (except forsource
, which already had it)network
: update definitions and examples wrt lowercase directiveuser_agent.original
index is nowkeyword
indexed (See Indexuser_agent.original
, after all. ecs#262)ecs.version
example <= this is of staggering importance! Just kiddingTODO
make check
fails, no wonderos
here, or in a separate PR?