Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic.CommonSchema.NLog - MetadataDictionary with safe values #222

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 10, 2022

System.Text.Json is very fragile, and can only handle safe objects

If it was possible to control the recursion-level of the System.Text.Json to only first level (Default=32) for unsafe objects could also be nice:

https://docs.microsoft.com/en-us/dotnet/api/system.text.json.jsonserializeroptions.maxdepth

@apmmachine
Copy link
Contributor

apmmachine commented Sep 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-16T15:59:10.516+0000

  • Duration: 17 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 178
Skipped 2
Total 180

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@snakefoot snakefoot force-pushed the nlog-metadata-protection branch 3 times, most recently from 76f670c to e9c5ce5 Compare September 10, 2022 18:25
@snakefoot snakefoot force-pushed the nlog-metadata-protection branch from e9c5ce5 to 7a2bd5a Compare September 11, 2022 17:42
@Mpdreamz
Copy link
Member

Jenkins run tests please

@snakefoot snakefoot force-pushed the nlog-metadata-protection branch from 4863992 to 2eb50ac Compare January 13, 2023 19:47
@Mpdreamz Mpdreamz added bug Something isn't working v8.4.0 labels Jan 16, 2023
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update to support NLOG message templates defaults of ToString() with better support for @ destructuring properties!

@Mpdreamz
Copy link
Member

Jenkins run tests please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants