Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EcsJsonConfiguration - With converters to protect against bad types #221

Merged
merged 3 commits into from
Jan 16, 2023
Merged

EcsJsonConfiguration - With converters to protect against bad types #221

merged 3 commits into from
Jan 16, 2023

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 10, 2022 •
edited
Loading

Trying resolve #219

@snakefoot snakefoot force-pushed the MetadataDictionaryConverter_BadTypes branch from 6abf7ef to cca4c84 Compare September 10, 2022 10:50
@apmmachine
Copy link
Contributor

apmmachine commented Sep 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-16T18:54:20.240+0000

  • Duration: 18 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 186
Skipped 2
Total 188

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@snakefoot snakefoot force-pushed the MetadataDictionaryConverter_BadTypes branch 6 times, most recently from 5212353 to debc99b Compare September 10, 2022 12:34
@snakefoot snakefoot changed the title MetadataDictionaryConverter - Protect against bad types EcsJsonConfiguration - With converters to protect against bad types Sep 10, 2022
@snakefoot snakefoot force-pushed the MetadataDictionaryConverter_BadTypes branch 4 times, most recently from e8910fa to c52cd1d Compare September 10, 2022 14:05
@snakefoot snakefoot mentioned this pull request Sep 11, 2022
Closed
@snakefoot snakefoot force-pushed the MetadataDictionaryConverter_BadTypes branch 2 times, most recently from ea79431 to b7c4a96 Compare September 11, 2022 12:40
@Mpdreamz
Copy link
Member

Jenkins run tests please

@snakefoot snakefoot force-pushed the MetadataDictionaryConverter_BadTypes branch 2 times, most recently from 981de12 to 86b7c14 Compare January 16, 2023 17:12
@snakefoot
Copy link
Contributor Author

@Mpdreamz Merge conflicts now resolved

@snakefoot snakefoot force-pushed the MetadataDictionaryConverter_BadTypes branch from 86b7c14 to 46b957b Compare January 16, 2023 17:23
@snakefoot snakefoot force-pushed the MetadataDictionaryConverter_BadTypes branch from 46b957b to af8e21d Compare January 16, 2023 17:24
@Mpdreamz
Improve safety of MetadataDictionaryConverter
a8bb26b 
Ensure a failure of writing a property does not fail to write the whole log.

Serialization failures are not stashed under `metadata.__failures__`.

Make sure NLog tests flushes test logs to XUnit's Test Output so they can be easily inspected in test runners
@Mpdreamz
Copy link
Member

Mpdreamz commented Jan 16, 2023 •
edited
Loading

Thanks @snakefoot!

I ammended this PR to improve the overall safety MetadataDictionaryConverter.
Ensuring an exception during the writing of a key's value does not fail to write the whole log.

Serialization failures are now stashed under metadata.__failures__.

Also made sure NLog tests flushes the logs to XUnit's Test Output so they can be easily inspected in test runners.

@Mpdreamz
Copy link
Member

Jenkins run tests please

@Mpdreamz Mpdreamz added bug Something isn't working v8.4.0 labels Jan 16, 2023
@Mpdreamz Mpdreamz merged commit 547e182 into elastic:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] MetaDataDictionaryConverter - NullReferenceException
3 participants
@snakefoot @apmmachine @Mpdreamz