Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

fix: proper usage of step #883

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Mar 12, 2021

What does this PR do?

It uses the proper signature for the isUpstreamTrigger step.

Why is it important?

Passing a simple string causes a signature error when running the pipeline. 🤦

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

Follow-up

Add backport commits to #880 #881 and #882

@mdelapenya mdelapenya self-assigned this Mar 12, 2021
@mdelapenya mdelapenya requested a review from a team March 12, 2021 06:32
@mdelapenya mdelapenya marked this pull request as ready for review March 12, 2021 06:32
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #883 opened

  • Start Time: 2021-03-12T06:32:31.273+0000

  • Duration: 23 min 8 sec

  • Commit: e016aac

Test stats 🧪

Test Results
Failed 0
Passed 109
Skipped 0
Total 109

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 109
Skipped 0
Total 109

@mdelapenya mdelapenya merged commit 70b1d3d into elastic:master Mar 12, 2021
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 12, 2021
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 12, 2021
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 12, 2021
mdelapenya added a commit that referenced this pull request Mar 12, 2021
…7.11.x (#882)

* feat: run most frequent flavours in the PR stage (#873)

* chore: decouple centos from debian in BDD examples

This change will support the selection of centos, debian or both when
running the tests. Therefore the CI will be able to run only tests for
centos in the PR phase, speeding up the PR build: The other OSs could be
run in the nightly build

* feat: run centos in the PR phase

* feat: do not run ubi8 in the PR phase

* fix: negate tags to skip only those ones

* fix: enclose variable in double quotes

* fix: add whitespaces

* fix: defensive programming for the new key

* chore: move old MySQL versions to the nightly build

Because there is only one variant, we are removing the @variant tag

* chore: use PR filter for MySQL YAML descritor

* chore: move MySQL 5.7 to the PR phase

* chore: move Percona out to the PR phase

* chore: append PR filter for upstream PRs

* chore: support running endpoint tests for debian

* chore: move endpoint processes to the process feature file

* chore: do not add Debian tests for PRs in endpoint test suite

* fix: proper usage of step (#883)
mdelapenya added a commit that referenced this pull request Mar 12, 2021
…7.12.x (#881)

* feat: run most frequent flavours in the PR stage (#873)

* chore: decouple centos from debian in BDD examples

This change will support the selection of centos, debian or both when
running the tests. Therefore the CI will be able to run only tests for
centos in the PR phase, speeding up the PR build: The other OSs could be
run in the nightly build

* feat: run centos in the PR phase

* feat: do not run ubi8 in the PR phase

* fix: negate tags to skip only those ones

* fix: enclose variable in double quotes

* fix: add whitespaces

* fix: defensive programming for the new key

* chore: move old MySQL versions to the nightly build

Because there is only one variant, we are removing the @variant tag

* chore: use PR filter for MySQL YAML descritor

* chore: move MySQL 5.7 to the PR phase

* chore: move Percona out to the PR phase

* chore: append PR filter for upstream PRs

* chore: support running endpoint tests for debian

* chore: move endpoint processes to the process feature file

* chore: do not add Debian tests for PRs in endpoint test suite

* fix: proper usage of step (#883)
mdelapenya added a commit that referenced this pull request Mar 12, 2021
…7.x (#880)

* feat: run most frequent flavours in the PR stage (#873)

* chore: decouple centos from debian in BDD examples

This change will support the selection of centos, debian or both when
running the tests. Therefore the CI will be able to run only tests for
centos in the PR phase, speeding up the PR build: The other OSs could be
run in the nightly build

* feat: run centos in the PR phase

* feat: do not run ubi8 in the PR phase

* fix: negate tags to skip only those ones

* fix: enclose variable in double quotes

* fix: add whitespaces

* fix: defensive programming for the new key

* chore: move old MySQL versions to the nightly build

Because there is only one variant, we are removing the @variant tag

* chore: use PR filter for MySQL YAML descritor

* chore: move MySQL 5.7 to the PR phase

* chore: move Percona out to the PR phase

* chore: append PR filter for upstream PRs

* chore: support running endpoint tests for debian

* chore: move endpoint processes to the process feature file

* chore: do not add Debian tests for PRs in endpoint test suite

* fix: proper usage of step (#883)
@mdelapenya mdelapenya deleted the fix-filter branch March 15, 2021 09:20
v1v added a commit to v1v/e2e-testing that referenced this pull request Mar 15, 2021
…hings

* upstream/master:
  [CI] tear down the workspace (elastic#885)
  docs: add Make as build system (elastic#886)
  fix: proper usage of step (elastic#883)
  feat: run most frequent flavours in the PR stage (elastic#873)
  break: move from "pull-requests" to "commits" GCP bucket (elastic#866)
  fix: use proper flags (elastic#868)
  feat: instrument Helm charts test suite (elastic#858)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants