This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
break: move from "pull-requests" to "commits" GCP bucket #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
jenkins run the tests |
v1v
approved these changes
Mar 10, 2021
e2e/_suites/fleet/installers.go
Outdated
| @@ -204,7 +204,6 @@ func (i *DockerPackage) Preinstall() error { | |||
| e2e.Sleep(3 * time.Second) | |||
|
|
|||
| // we need to tag the loaded image because its tag relates to the target branch, | |||
mdelapenya
commented
Mar 10, 2021
mdelapenya
commented
Mar 10, 2021
|
I think the failures will be fixed by #868 |
cachedout
approved these changes
Mar 11, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 11, 2021
* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 11, 2021
* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 11, 2021
* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 11, 2021
* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos
mdelapenya
added a commit
that referenced
this pull request
Mar 11, 2021
mdelapenya
added a commit
that referenced
this pull request
Mar 11, 2021
mdelapenya
added a commit
that referenced
this pull request
Mar 12, 2021
v1v
added a commit
to v1v/e2e-testing
that referenced
this pull request
Mar 15, 2021
…hings * upstream/master: [CI] tear down the workspace (elastic#885) docs: add Make as build system (elastic#886) fix: proper usage of step (elastic#883) feat: run most frequent flavours in the PR stage (elastic#873) break: move from "pull-requests" to "commits" GCP bucket (elastic#866) fix: use proper flags (elastic#868) feat: instrument Helm charts test suite (elastic#858)
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes all code using the
pr-prefix, so that we are going to support triggering Beats builds (from PRs or branches) without adding the BEAT_VERSION. Instead we are going to pass theGITHUB_CHECK_SHA1, only.For that reason, we will use the
commitsbucket instead of thepull-requestsone, downloading and consuming the artifacts from the first bucket.Why is it important?
Firstly, to fix errors on Beats PR: https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/7.12.x/27/pipeline/223/ It seems the PR is not calculating the right filename, not resolving the alias and therefore failing in an horrible manner because the artifact cannot be fetched 🤦♀️
Second, simplicity: supporting less modes simplifies the codebase.
Finally, reproducibility. A PR could receive another commit without being notified. Using commits will allow us to couple e2e tests execution with exact code.
Checklist
make noticein the proper directory)Author's Checklist
How to test this PR locally
Related issues
Follow-ups
We must update the packaging job on Beats, to not pass the BEATS_VERSION variable, and use the one in the defined branch.