Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Add max_signal note, unit test, and rule tuning #3669

Merged
merged 8 commits into from
May 14, 2024
Merged

[FR] Add max_signal note, unit test, and rule tuning #3669

merged 8 commits into from
May 14, 2024

Conversation

Mikaayenson
Copy link
Contributor

@Mikaayenson Mikaayenson commented May 13, 2024 •
edited
Loading

Issues

Resolves #3666

Summary

Bug Fixes

  • Updates a unit test that originally had a bad assert method self.assert_

@Mikaayenson Mikaayenson added python Internal python for the repository Area: DED Team: TRADE labels May 13, 2024
@Mikaayenson Mikaayenson requested a review from a team May 13, 2024 20:48
@Mikaayenson Mikaayenson self-assigned this May 13, 2024
@Mikaayenson Mikaayenson linked an issue May 13, 2024 that may be closed by this pull request
[Rule Tuning] Add Unit Test and Note for max_signals #3666
Closed
@botelastic botelastic bot added the Integration: Endpoint Elastic Endpoint Security label May 13, 2024
eric-forte-elastic
eric-forte-elastic approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@eric-forte-elastic eric-forte-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Manual review, looks good to me! 👍

terrancedejesus
terrancedejesus approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@terrancedejesus terrancedejesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change ## Setup to "setup" field and we should be good!

rules/promotions/credential_access_endgame_cred_dumping_prevented.toml Outdated Show resolved Hide resolved
banderror
banderror reviewed May 14, 2024
View reviewed changes
Copy link

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, thanks @Mikaayenson! One suggestion for the wording.

rules/integrations/cloud_defend/container_workload_protection.toml Outdated Show resolved Hide resolved
@Mikaayenson Mikaayenson merged commit f07a9e6 into main May 14, 2024
14 checks passed
@Mikaayenson Mikaayenson deleted the 3666-rule-tuning-add-unit-test-and-note-for-max_signals branch May 14, 2024 16:15
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
7b15e55 
Removed changes from:
- rules/integrations/cloud_defend/container_workload_protection.toml

(selectively cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
99190e2 
Removed changes from:
- rules/integrations/cloud_defend/container_workload_protection.toml

(selectively cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
6563abe 
Removed changes from:
- rules/integrations/cloud_defend/container_workload_protection.toml

(selectively cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
2e30a3c 
Removed changes from:
- rules/integrations/cloud_defend/container_workload_protection.toml

(selectively cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
a6c9642 
Removed changes from:
- rules/integrations/cloud_defend/container_workload_protection.toml

(selectively cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
2ea2593 
(cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
f2730dd 
(cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
6aae09a 
(cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
ca8af12 
(cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
edf9f8b 
(cherry picked from commit f07a9e6)
protectionsmachine pushed a commit that referenced this pull request May 14, 2024
@Mikaayenson @github-actions
[FR] Add max_signal note, unit test, and rule tuning (#3669)
ef8cb3a 
(cherry picked from commit f07a9e6)
@banderror banderror mentioned this pull request May 22, 2024
Closed
16 tasks
@banderror banderror mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples left review comments

@banderror banderror banderror left review comments

@eric-forte-elastic eric-forte-elastic eric-forte-elastic approved these changes

@terrancedejesus terrancedejesus terrancedejesus approved these changes

@brokensound77 brokensound77 Awaiting requested review from brokensound77

Assignees

@Mikaayenson Mikaayenson

Labels
backport: auto community Integration: Endpoint Elastic Endpoint Security python Internal python for the repository Team: TRADE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rule Tuning] Add Unit Test and Note for max_signals
5 participants
@Mikaayenson @banderror @joepeeples @terrancedejesus @eric-forte-elastic