Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Tuning] Add Unit Test and Note for max_signals #3666

Closed
Mikaayenson opened this issue May 13, 2024 · 0 comments · Fixed by #3669
Closed

[Rule Tuning] Add Unit Test and Note for max_signals #3666

Mikaayenson opened this issue May 13, 2024 · 0 comments · Fixed by #3669
Assignees
Labels
community enhancement New feature or request python Internal python for the repository Team: TRADE

Comments

@Mikaayenson
Copy link
Contributor

Mikaayenson commented May 13, 2024

Summary

There are prebuilt rules with max_signals = 10k and the system_limit = 1000 (slack)

We need to update the setup guide to warn the users that those rules that have max_signals > system_limit will be generating at most system_limit alerts per execution (1000 by default) and system_limit = xpack.alerting.rules.run.alerts.max = 1000 by default; can be increased by the user via Kibana config.

We then need to add a unit test to make sure this warning is added when max_signals > system_limit.

Note: in Serverless, users are not able to adjust the system_limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request python Internal python for the repository Team: TRADE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant