-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve parsing #51
Conversation
Signed-off-by: Amund Tenstad <[email protected]>
This is very nice!
Could you update Suggestion but feel free to rename: // UnderlyingType tests that A.UnderlyingType equals B instead of string.
// +kubebuilder:object:root=true
type UnderlyingType struct {
A A `json:"a,omitempty"`
}
type A B
type B string I think we need to adapt |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
81eb5f7
to
319af4e
Compare
Added the test in two commits, where the 2nd (319af4e) shows the changes introduced by this PR. |
Wondering if we should update the rendering so that the test types we added renders as they used to 🤔 |
Having different descriptions, I guess it is nice to show both Underlying1 and Underlying2 :) |
What if we display Underlying type: in both adoc and markdown. And show the type as in a struct field? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We really appreciate your contribution, thanks again.
Simplifies a lot of the complexity of having separate
processType
,loadType
andloadAliasType
.Removes ArrayKind, as it is not supported by controller-gen.
Also ensures correct parsing of
A
in the example below, makingA.UnderlyingType
equalB
instead ofstring
. This will be required to correctly parse and propagate markers (#49).