-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update default templates with default and validation markers #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
Merged
tenstad
force-pushed
the
markers
branch
2 times, most recently
from
August 17, 2023 06:26
6e7a359
to
d2dcdaf
Compare
2 tasks
Any plans to merge this? |
thbkrkr
reviewed
Feb 14, 2024
Co-authored-by: Thibault Richard <[email protected]>
thbkrkr
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, @tenstad.
thbkrkr
changed the title
feat: process markers
feat: update default templates with default and validation markers
Feb 14, 2024
looks amazing 🚀 looking forward for the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processes kubebuilder validation and default markers, and exposes them through the fields
Validation
andDefault
. These are displayed in two new struct field columns, and validation is shown in type descriptions.We could introduce this without updating the default template, so that those who want can start using Default and Validation without affecting existing usage.
WONTFIX
Example doc