[Bugfix] Throw DocumentNotFoundError if index doesnt exist when looking for doc by id

[jedrazb]

Changes

NotFoundError -> DocumentNotFoundError (consistent with the rest of framework)

The index refresh operation should be wrapped in a try/catch block. Otherwise, if we’re searching for a document in an index that doesn’t exist yet, it throws a NotFoundError instead of a DocumentNotFoundError. In my opinion, if the document doesn’t exist because the underlying index is missing, we should still return a DocumentNotFoundError. This also simplifies the caller logic, as we only need to handle a single exception type.

Update logs from critical to error. In my opinion, the critical log level should be reserved for cases that cause the entire framework to fail. In most, if not all, of these cases, we either retry or have some graceful handling, so it’s appropriate to log them at just the error level.

[github-actions]

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2916 --autoMerge --autoMergeMethod squash