Skip to content

Commit

Permalink
[Bugfix] Throw DocumentNotFoundError if index doesnt exist when looki…
Browse files Browse the repository at this point in the history
…ng for doc by id (#2916)
  • Loading branch information
jedrazb authored Oct 24, 2024
1 parent cc63d7b commit 18d2464
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions connectors/es/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,18 +217,18 @@ async def fetch_by_id(self, doc_id):
return self._create_object(resp_body)

async def fetch_response_by_id(self, doc_id):
if not self.serverless:
await self._retrier.execute_with_retry(
partial(self.client.indices.refresh, index=self.index_name)
)

try:
if not self.serverless:
await self._retrier.execute_with_retry(
partial(self.client.indices.refresh, index=self.index_name)
)

resp = await self._retrier.execute_with_retry(
partial(self.client.get, index=self.index_name, id=doc_id)
)
except ApiError as e:
logger.critical(f"The server returned {e.status_code}")
logger.critical(e.body, exc_info=True)
logger.error(f"The server returned {e.status_code}")
logger.error(e.body, exc_info=True)
if e.status_code == 404:
msg = f"Couldn't find document in {self.index_name} by id {doc_id}"
raise DocumentNotFoundError(msg) from e
Expand Down

0 comments on commit 18d2464

Please sign in to comment.