Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updatecli] Update hermit and pre-commit dependencies #2705

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

cloudsecmachine
Copy link
Collaborator

What

Run hermit upgrade and pre-commit autoupdate.

Generated automatically with https://github.com/elastic/cloudbeat/actions/runs/11773771086


Update Hermit and Pre-commit Dependencies

Update hermit and pre-commit packages

ran shell command ".ci/updatecli/scripts/update-hermit.sh"

GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@romulets romulets enabled auto-merge (squash) November 12, 2024 08:41
@romulets
Copy link
Member

Updates:

  • exportloopref has been deprecated and replaced by copyloopvar (link). 1.22+ onwards we don't need to do the var copy loop 🥳
  • testifylint got a few updates. What affected us:
    • regexp: remove unnecessary regexp.MustCompile (testifylint) (link)
    • formatter: remove unnecessary fmt.Sprintf (testifylint) (link)

@orestisfl
Copy link
Contributor

Updates:

* `exportloopref` has been deprecated and replaced by `copyloopvar` ([link](https://golangci-lint.run/usage/linters/#copyloopvar)). 1.22+ onwards we don't need to do the var copy loop  🥳

* `testifylint` got [a few updates](https://github.com/Antonboom/testifylint/releases/tag/v1.5.0). What affected us:
  
  * regexp: remove unnecessary regexp.MustCompile (testifylint) ([link](https://github.com/Antonboom/testifylint/pull/136))
  * formatter: remove unnecessary fmt.Sprintf (testifylint) ([link](https://github.com/Antonboom/testifylint/pull/188))

See also:
https://github.com/golangci/golangci-lint/releases/tag/v1.62.0

https://github.com/uudashr/iface

iface is a linter designed to identify the incorrect use of
interfaces in Go code, helping developers avoid interface pollution.
By detecting unnecessary or poorly implemented interfaces, iface
ensures your Go code remains clean, efficient, and maintainable.

https://github.com/raeperd/recvcheck

Golang linter for check receiver type in method

@romulets romulets merged commit 078b40b into main Nov 12, 2024
11 checks passed
@romulets romulets deleted the updatecli_main_updatecli-hermit-main branch November 12, 2024 09:52
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
* chore: Update hermit and pre-commit packages

Made with ❤️️ by updatecli

* chore: Update hermit and pre-commit packages

Made with ❤️️ by updatecli

* Fix lint errors

---------

Co-authored-by: Rômulo Farias <[email protected]>
(cherry picked from commit 078b40b)
romulets pushed a commit that referenced this pull request Nov 12, 2024
…encies (#2710)

[updatecli] Update hermit and pre-commit dependencies (#2705)

* chore: Update hermit and pre-commit packages

Made with ❤️️ by updatecli

* chore: Update hermit and pre-commit packages

Made with ❤️️ by updatecli

* Fix lint errors

---------

Co-authored-by: Rômulo Farias <[email protected]>
(cherry picked from commit 078b40b)

Co-authored-by: cloudsecmachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants