Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new checker 'regexp' #136

Merged
merged 2 commits into from
Jun 21, 2024
Merged

new checker 'regexp' #136

merged 2 commits into from
Jun 21, 2024

Conversation

Antonboom
Copy link
Owner

@Antonboom Antonboom commented Jun 20, 2024

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9601905089

Details

  • 38 of 43 (88.37%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 93.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_pkg_func.go 11 13 84.62%
internal/checkers/regexp.go 14 17 82.35%
Totals Coverage Status
Change from base Build 9601011094: -0.06%
Covered Lines: 2172
Relevant Lines: 2319

💛 - Coveralls

Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one readability remark, but LGTM 👍

Btw isPkgFnCall is a great addition 🎉

internal/checkers/regexp.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9607884797

Details

  • 39 of 44 (88.64%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 93.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/helpers_pkg_func.go 11 13 84.62%
internal/checkers/regexp.go 15 18 83.33%
Totals Coverage Status
Change from base Build 9607744222: -0.06%
Covered Lines: 2173
Relevant Lines: 2320

💛 - Coveralls

@Antonboom Antonboom merged commit 8c863c6 into master Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regexp: simplify assert.Regexp(t, regexp.MustCompile)
3 participants