License check annotation #5815
Merged
License check annotation #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the latter to break import cycles
8 tasks
naemono
approved these changes
Jun 22, 2022
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
Support an annotation on all Elastic resources to request a certain license level in the operator. Pre-req of elastic#5781 I had to move a few things around for this to break a few import cycles, I hope that the changes and new packages names are self-explanatory and generally an improvement over the status quo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support an annotation on all Elastic resources to request a certain license level in the operator. Pre-req of #5781
I had to move a few things around for this to break a few import cycles, I hope that the changes and new packages names are self-explanatory and generally an improvement over the status quo.
I feel like there is room for a larger refactoring of the web hook logic in which we use just one method for both Elasticsearch and all the other applications. Also I found #5814